Don't vendor nlohmann_json when USE_SYSTEM_DEPS is on.#324
Merged
auscaster merged 2 commits intonilstate:mainfrom Apr 11, 2026
Merged
Don't vendor nlohmann_json when USE_SYSTEM_DEPS is on.#324auscaster merged 2 commits intonilstate:mainfrom
auscaster merged 2 commits intonilstate:mainfrom
Conversation
…ten by gpt-5.3-codex.
dg0yt
reviewed
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the vcpkg repo we observe a conflict with the icey port and the nlohmann_json port:
gpt-5.3-codex wrote this patch to not vendor nlohmann_json when USE_SYSTEM_DEPS is on. However, the fix proposed in microsoft/vcpkg#51086 also depends on deleting the file out of the repo before we build it, which presumably you might not want to do here.